PR review

SonarSource · Dec 7, 2023 · ebc2e6a · ebc2e6a
1 parent cbd4a04
commit ebc2e6a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/main/java/org/sonarlint/intellij/finding/persistence/FindingPersistence.java b/src/main/java/org/sonarlint/intellij/finding/persistence/FindingPersistence.java
@@ -72,9 +72,12 @@ public synchronized boolean contains(String key) {
     return store.contains(key);
   }
 
-  public synchronized void save(String key, Collection<T> findings) throws IOException {
-    FileUtils.mkdirs(storeBasePath);
-    store.write(key, transform(findings));
+  public void save(String key, Collection<T> findings) throws IOException {
+    var findingsToWrite = transform(findings);
+    synchronized (this) {
+      FileUtils.mkdirs(storeBasePath);
+      store.write(key, findingsToWrite);
+    }
   }
 
   public synchronized void clear(String key) throws IOException {

diff --git a/src/main/java/org/sonarlint/intellij/finding/persistence/LiveFindingCache.java b/src/main/java/org/sonarlint/intellij/finding/persistence/LiveFindingCache.java
@@ -158,7 +158,7 @@ public void clear() {
   }
 
   public boolean contains(VirtualFile virtualFile) {
-    return getLive(virtualFile) != null;
+    return cache.containsKey(virtualFile);
   }
 
   private String createKey(VirtualFile virtualFile) {

diff --git a/src/test/java/org/sonarlint/intellij/finding/persistence/LiveFindingCacheTests.java b/src/test/java/org/sonarlint/intellij/finding/persistence/LiveFindingCacheTests.java
@@ -72,7 +72,7 @@ void should_save_and_read_cache_only() throws IOException {
   }
 
   @Test
-  void should_flush_if_full() throws IOException {
+  void should_flush_if_full() {
     var issue1 = createTestIssue("r1");
     var file0 = myFixture.copyFileToProject("foo.php", "foo0.php");
     cache.replaceFindings(Map.of(file0, List.of(issue1)));
@@ -168,7 +168,6 @@ void testConcurrentAccess() throws Exception {
     for (Future<?> task : tasks) {
       task.get(1, TimeUnit.MINUTES);
     }
-
   }
 
   private LiveIssue createTestIssue(String ruleKey) {