Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLI-1521 TreeUI should be accessed only from EDT #1148

Merged
merged 1 commit into from
Aug 29, 2024
Merged

SLI-1521 TreeUI should be accessed only from EDT #1148

merged 1 commit into from
Aug 29, 2024

Conversation

eray-felek-sonarsource
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource commented Aug 29, 2024 •
edited by jira bot
Loading

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1521-access-treeui-from-edt branch from 6d18ce2 to 08db5d6 Compare August 29, 2024 11:04
nquinquenel
nquinquenel reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried removing this OccurrenceNavigator completely?

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1521-access-treeui-from-edt branch from 08db5d6 to 6a34ecb Compare August 29, 2024 11:16
@eray-felek-sonarsource
Copy link
Contributor Author

eray-felek-sonarsource commented Aug 29, 2024 •
edited
Loading

Have you tried removing this OccurrenceNavigator completely?

Yes, nothing has changed, I think we should continue with removal since it is unnecessary for our use cases

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1521-access-treeui-from-edt branch from 15fb2bb to 73aefc8 Compare August 29, 2024 11:19
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1521-access-treeui-from-edt branch from 73aefc8 to b161396 Compare August 29, 2024 11:29
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@eray-felek-sonarsource eray-felek-sonarsource merged commit fb4f234 into master Aug 29, 2024
31 checks passed
@eray-felek-sonarsource eray-felek-sonarsource deleted the feature/ef/SLI-1521-access-treeui-from-edt branch August 29, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nquinquenel nquinquenel nquinquenel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eray-felek-sonarsource @nquinquenel