Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLLS-284 accept path to eslint bridge server bundle #421

Merged
merged 3 commits into from
Dec 10, 2024
Merged

SLLS-284 accept path to eslint bridge server bundle #421

merged 3 commits into from
Dec 10, 2024

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource commented Dec 6, 2024 •
edited by jira bot
Loading

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource marked this pull request as draft December 6, 2024 10:21
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLLS-284_eslint_bridge_path_param branch 2 times, most recently from e2b4aa1 to c155a86 Compare December 6, 2024 14:43
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLLS-284_eslint_bridge_path_param branch from c155a86 to e994574 Compare December 6, 2024 14:46
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource marked this pull request as ready for review December 9, 2024 14:38
jblievremont
jblievremont requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment about theadditionalAttributes field.

src/main/java/org/sonarsource/sonarlint/ls/SonarLintLanguageServer.java Outdated Show resolved Hide resolved
jblievremont
jblievremont approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLLS-284_eslint_bridge_path_param branch from 7025616 to 84c0bae Compare December 10, 2024 10:23
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLLS-284_eslint_bridge_path_param branch from 84c0bae to 3348562 Compare December 10, 2024 10:26
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit 728da48 into master Dec 10, 2024
6 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the SLLS-284_eslint_bridge_path_param branch December 10, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblievremont jblievremont jblievremont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophio-japharidze-sonarsource @jblievremont