Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLLS-283 Use monitoring facility from core backend #426

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

jblievremont
Copy link
Member

@jblievremont jblievremont commented Dec 20, 2024

@@ -62,6 +62,8 @@

public class BackendServiceFacade {

public static final String MONITORING_DISABLED_PROPERTY_KEY = "sonarlint.monitoring.disabled";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is set in the SLLS tests and will also be set in the SLVSCODE tests 🙈

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reverse the name, it will make everything much easier to follow. i.e. MONITORING_ENABLED_PROPERTY_KEY = "sonarlint.monitoring.enabled"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm half-and-half on this one.

I agree that it would make it somewhat easier to follow, but it would also be less consistent with the property that governs telemetry (and the default behavior is to have monitoring enabled, hence the property to disable it).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I always spend a couple of extra brain cells on computing the actual value of telemetry enabled/disabled because of that :D

OK, we can leave it as is I guess, for the sake of consistency 😢 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! ⭐
See my suggestion about naming 🙈

@@ -62,6 +62,8 @@

public class BackendServiceFacade {

public static final String MONITORING_DISABLED_PROPERTY_KEY = "sonarlint.monitoring.disabled";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reverse the name, it will make everything much easier to follow. i.e. MONITORING_ENABLED_PROPERTY_KEY = "sonarlint.monitoring.enabled"

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit 3cb4e06 into master Dec 24, 2024
6 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the SLLS-283-monitoring branch December 24, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants