Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVSCODE-846 stop using additionalAttributes map #432

Merged
merged 1 commit into from
Jan 3, 2025
Merged

SLVSCODE-846 stop using additionalAttributes map #432

merged 1 commit into from
Jan 3, 2025

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource commented Jan 2, 2025 •
edited by jira bot
Loading

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLVSCODE-846_move_away_from_additionalAttributes branch 2 times, most recently from 1538f2b to d3a8d83 Compare January 2, 2025 16:00
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLVSCODE-846_move_away_from_additionalAttributes branch from d3a8d83 to 0d1d0e3 Compare January 3, 2025 08:54
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jan 3, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

thahnen
thahnen approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@thahnen thahnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit 70be16c into master Jan 3, 2025
8 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the SLVSCODE-846_move_away_from_additionalAttributes branch January 3, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thahnen thahnen thahnen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophio-japharidze-sonarsource @thahnen