Size the lists of nodes

SonarSource · Apr 19, 2018 · d863c02 · d863c02
1 parent 5841761
commit d863c02
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/sslr-core/src/main/java/com/sonar/sslr/impl/typed/SyntaxTreeCreator.java b/sslr-core/src/main/java/com/sonar/sslr/impl/typed/SyntaxTreeCreator.java
@@ -76,28 +76,29 @@ private Object visitNonTerminal(ParseNode node) {
 
     Object result;
 
+    List<ParseNode> children = node.getChildren();
     if (mapping.hasMethodForRuleKey(ruleKey)) {
 
       // TODO Drop useless intermediate nodes
-      if (node.getChildren().size() != 1) {
+      if (children.size() != 1) {
         throw new IllegalStateException();
       }
-      result = visit(node.getChildren().get(0));
+      result = visit(children.get(0));
 
     } else if (mapping.isOptionalRule(ruleKey)) {
 
-      if (node.getChildren().size() > 1) {
+      if (children.size() > 1) {
         throw new IllegalStateException();
       }
-      if (node.getChildren().isEmpty()) {
+      if (children.isEmpty()) {
         result = Optional.absent();
       } else {
-        result = Optional.of(visit(node.getChildren().get(0)));
+        result = Optional.of(visit(children.get(0)));
       }
 
     } else {
-      List<Object> convertedChildren = new ArrayList<>();
-      for (ParseNode child : node.getChildren()) {
+      List<Object> convertedChildren = new ArrayList<>(children.size());
+      for (ParseNode child : children) {
         convertedChildren.add(visit(child));
       }
       if (mapping.isOneOrMoreRule(ruleKey)) {