Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sal/rtc code #68

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Sal/rtc code #68

wants to merge 8 commits into from

Conversation

ssalcedo00
Copy link
Contributor

Added realTimeClock.h so that we can setup the RTC on the teensy and use some of the <TimeLib.h> functionality to name our files

fazerlicourice7
fazerlicourice7 suggested changes Apr 11, 2021
View reviewed changes
Copy link
Contributor

@fazerlicourice7 fazerlicourice7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to actually set the file name in config.h for each different env.
And you have merge conflicts you need to fix.

lib/realTimeClock/realTimeClock.h Outdated Show resolved Hide resolved
@ssalcedo00 ssalcedo00 requested a review from nlautrette as a code owner April 13, 2021 06:40
@ssalcedo00
Copy link
Contributor Author

I also think that it is already writing to a new file at every boot

fazerlicourice7
fazerlicourice7 suggested changes Apr 14, 2021
View reviewed changes
platformio.ini Outdated Show resolved Hide resolved
src/E1_coldflow/E1_coldflow.cpp Outdated Show resolved Hide resolved
lib/common_fw/common_fw.h Outdated Show resolved Hide resolved
fazerlicourice7
fazerlicourice7 reviewed Apr 14, 2021
View reviewed changes
Copy link
Contributor

@fazerlicourice7 fazerlicourice7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool Looks good.
two tiny things
have you tested this out, make sure it works as expected?

lib/common_fw/common_fw.h
@@ -9,6 +9,7 @@

#include <string>
#include <cstring>
#include <sstream>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

platformio.ini
Comment on lines +11 to +12
[platformio]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@fazerlicourice7
Copy link
Contributor

update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fazerlicourice7 fazerlicourice7 fazerlicourice7 requested changes

@nlautrette nlautrette Awaiting requested review from nlautrette nlautrette is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssalcedo00 @fazerlicourice7