Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Programvareverkstedet #260

Merged
merged 1 commit into from
May 19, 2024
Merged

Add Programvareverkstedet #260

merged 1 commit into from
May 19, 2024

Conversation

h7x4
Copy link
Contributor

@h7x4 h7x4 commented May 18, 2024

No description provided.

@s3lph
Copy link
Contributor

s3lph commented May 19, 2024

Hi @h7x4, thanks for your contribution.

It appears that your endpoint does not set a CORS header (Access-Control-Allow-Origin: *), meaning that web-based SpaceAPI clients will not be able to use your endpoint. Would it be possible to add this header to your endpoint?

You can check for schema compliance and things like the missing CORS header in our validator: https://validator.spaceapi.io/ui/?url=https://www.pvv.ntnu.no/spaceapi.php

@h7x4
Copy link
Contributor Author

h7x4 commented May 19, 2024

@s3lph thank you for the heads up, should be fixed now

Copy link
Contributor

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 🚀

@s3lph s3lph merged commit c668084 into SpaceApi:master May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants