2981 rails 7 active storage #3822
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use check_all_pending! and alias_method
Remove require_dependencies
!! validates_uniqueness_of now compares "across the system", which apperently means unsaved objects in this case, this is very different behaviour (if interpretation is correct) that we may have to take into account in import scripts.
… into 2981_rails_7
* Move towards handling setting `cached_` values `after_commit`. This should help to eliminate the potential cascading touches on objects. * Updated original batch framework to save off by type, not row-by-row * TaxonName validate_parent_is_set is the same as one root per project, removed * Softened, but made more flexible cascading validation checks through `TaxonName#children` via changes to `TaxonName#parent_is_set?` * Removed the largely redundant subject/object validation in TaxonNameRelationship, this was added during Nomen batch load, and causes many redundant checks. Fixes to Batch save order made these unnecessary.
… into 2981_rails_7
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## development #3822 +/- ##
================================================
- Coverage 84.36% 25.73% -58.63%
================================================
Files 2131 1688 -443
Lines 79566 64771 -14795
================================================
- Hits 67123 16667 -50456
- Misses 12443 48104 +35661 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.