Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared sdram #582

Merged
merged 17 commits into from
Oct 21, 2024
Merged

Shared sdram #582

merged 17 commits into from
Oct 21, 2024

Conversation

Christian-B
Copy link
Member

Designed to be used with #581

Removals

  1. Subtraction between sdram object
    -Unused and make even less sense with SharedSdram
  2. vertet json mehtods
  • Unused. Can be replaced when the use case defines what is needed.

Changes.

  1. eq defintion moved to each sdram
  2. MultiRegionSDRAM now holds total as another sdram object
  • Many methods delegated to that sdram object
  1. MultiRegionSDRAM add_cost now uses nest method (as did the same thing)
  2. add methods changed to handle the extra type

SharedSdram
-Takes a dict of keys to sdram Objects

  • Optionally also a per_core sdram (mainly when summing)

@Christian-B Christian-B marked this pull request as draft October 21, 2024 07:32
@Christian-B Christian-B marked this pull request as ready for review October 21, 2024 10:46
@Christian-B Christian-B mentioned this pull request Oct 21, 2024
@rowleya rowleya merged commit cc29ec3 into master Oct 21, 2024
10 checks passed
@rowleya rowleya deleted the shared_sdram branch October 21, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants