use AbstractVertex rather than Union #588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the uses of type
Union[MachineVertex, ApplicationVertex]
with AbstractVertex
mypy correctly does not handle a mix of the two
includes:
SpiNNakerManchester/sPyNNaker#1524
https://github.com/SpiNNakerManchester/BitBrainDemo/pull/68
https://github.com/SpiNNakerManchester/TSPonSpiNNaker/pull/53