Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use AbstractVertex rather than Union #588

Merged
merged 2 commits into from
Jan 8, 2025
Merged

use AbstractVertex rather than Union #588

merged 2 commits into from
Jan 8, 2025

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Jan 7, 2025

Replacing the uses of type
Union[MachineVertex, ApplicationVertex]
with AbstractVertex

mypy correctly does not handle a mix of the two

includes:
SpiNNakerManchester/sPyNNaker#1524
https://github.com/SpiNNakerManchester/BitBrainDemo/pull/68
https://github.com/SpiNNakerManchester/TSPonSpiNNaker/pull/53

@rowleya rowleya merged commit 323e6b7 into master Jan 8, 2025
10 checks passed
@rowleya rowleya deleted the remove_vertex_union branch January 8, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants