Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recording data fixes #1209

Merged
merged 9 commits into from
Sep 11, 2024
Merged

recording data fixes #1209

merged 9 commits into from
Sep 11, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Sep 10, 2024

Followup to #1207 and #1202

  • Add a method to FecData say if this is the last/or only auto pause loop of a run
  • Only extract from AbstractReceiveRegionsToHost on the last/only loop
  • Change BufferManager.get_placement_data so that for AbstractReceiveRegionsToHost regions it returns ONLY the last data extracted
  • Removed the BufferManager.get_last_placement_data method as it is no longer needed.

To do this the database now tracks if the regions is_recording

  • True for regions where the data is appended on each loop
  • False for regions where the data is just the state at the end of the run
  • Cleaned up some columns that should have been removed in Simplfy the data.sqlite3 #1207

The Python tells the Java which placements to extract on each loop!

Must be done at the same time as:
SpiNNakerManchester/JavaSpiNNaker#1189
SpiNNakerManchester/sPyNNaker#1483

Tested by:
SpiNNakerManchester/IntegrationTests#290

@rowleya
Copy link
Member

rowleya commented Sep 10, 2024

A thought on this is that if we are now noting which regions are "recorded data" and which are not, we could use that to avoid region id clashing i.e. make it that the unique thing in the database is x, y, p, region_id, is_recorded. Then get_data_by_placement could also pass in whether it is reading a recorded data region or not.

@rowleya rowleya merged commit 9b18fcb into master Sep 11, 2024
11 checks passed
@rowleya rowleya deleted the rd2 branch September 11, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants