Typing for FEC #1245
Merged
Typing for FEC #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some small code changes:
LiveEventConnection.__do_receive_packet now only returns None
FecDataWriter.set_live_packet_gatherer_parameters( removed as unused
- view has an add method
-
graph_data_specification_writer no longer tires ApplicationVertices as they can not be AbstractGeneratesDataSpecification
AbstractGeneratesDataSpecification has abstract sdram_required
It had it indirectly via require_subclass stack
database_writer.py _extract_int method removed as unused
DataSpeedUpPacketGatherMachineVertex removed the pass in of a self variable to a private method called once
SQLiteDB methods execute and execute_many removed as kwargs methods
Replaced with
cursor()
and then the calls are
self.cursor().execute(...
Includes SpiNNakerManchester/sPyNNaker#1514
SpiNNakerManchester/SpiNNakerGraphFrontEnd#289
SpiNNakerManchester/SpiNNGym#97
https://github.com/SpiNNakerManchester/BitBrainDemo/pull/66
https://github.com/SpiNNakerManchester/TSPonSpiNNaker/pull/51
SpiNNakerManchester/MarkovChainMonteCarlo#73
SpiNNakerManchester/SpiNNaker_PDP2#90