Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOR related models #37

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

VOR related models #37

wants to merge 79 commits into from

Conversation

andrewgait
Copy link
Contributor

This work relates to an environment created to simulate an iCub reacting using networks containing the VOR-based models described in SpiNNakerManchester/sPyNNaker#1152. The actual code here should be self-contained and not refer to anything outside of SpiNNGym, but is itself used by the VOR cerebellum network (which is in a separate repository, PR there to follow).

andrewgait and others added 30 commits October 14, 2020 15:00
@andrewgait
Add bare bones of icub_vor environment
151a84b
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor
d439407 
- update icub_vor_env vertex to match others
@andrewgait
First working (simplified) ICubVorEnv vertex and example test
526026c
@andrewgait
Encode rates based on error and send to connected SpikeSourcePoisson
49ef436
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor
90ef1ac
@andrewgait
Update icub_vor to match other vertices, switch to [-1,1] for errors
db09210
@pabogdan
vor venv normalised error looks better
010b44b
@pabogdan
Merge remote-tracking branch 'origin/icub_vor' into icub_vor
9519b2e
@pabogdan
rolling back changes. head and eye norm better done in python.
781c228
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor
c0e0a01
@andrewgait
Update to remove compiler warnings for old-style function definitions
d6ae370
@pabogdan
added a comment to clarify what a check was doing
16be544
@pabogdan
Merge branch 'icub_vor' of github.com:SpiNNakerManchester/SpiNNGym in…
11c15e6 
…to icub_vor
@pabogdan
added eye twist movement
5c1a947
@pabogdan
eye position works well, eye velocity is broken completely
64c5e61
@pabogdan
eye velocity now matches as well. I wonder if the error can be brough…
40694e1 
…t down more.
@pabogdan
added some comments and a gain factor
a0b58a2
@pabogdan
retrieving eye positions, not head pos
8f764fd
@pabogdan
now writing gain and pos_to_vel from python
71a0f13
@pabogdan
head position now capped between -1 and 1
c39a69d
@pabogdan
not using head arrays anymore and corrected reading order for eye pos…
89c2c5a 
… and vel
@pabogdan
can now toggle between a WTA or a difference based decision
8b59f6c
@pabogdan
added ability to set min and max error rates
8bbf482
@pabogdan
fixing len checks to eye positions rather than the heads
112543a
@pabogdan
error computation biasing position
fade7f1
@pabogdan
current parameters work somewhat well for 5x slowdown (commit from vo…
76d758a 
…r_cerebellum)
@pabogdan
velocity is now the parameter that the network can influence
b7a8bb5
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
f62b7e3 
Conflicts:
	c_code/Makefile
@andrewgait
Update ICubVorEnv to match other vertices
1bcafde
@andrewgait
C code line length, unused params; update requirements
44c5ae0
andrewgait added 27 commits August 4, 2022 11:41
@andrewgait
Match downstream changes
f092003
@andrewgait
Merge branch 'master' into icub_vor_update
727385c
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
3f345e4 
Conflicts:
	spinn_gym/games/logic/logic.py
	spinn_gym/games/spinn_gym_application_vertex.py
@andrewgait
Update ICubVorEnv to match changes elsewhere
f56ff93
@andrewgait
Merge branch 'master' into icub_vor_update
1ae09d3
@andrewgait
Removing unused parameter found by pylint
06dee5a
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
4d663ae
@andrewgait
Merge branch 'master' into icub_vor_update
2b55efc
@andrewgait
Merge branch 'master' into icub_vor_update
d1a8f17
@andrewgait
Merge branch 'master' into icub_vor_update
d20b233
@andrewgait
Merge branch 'master' into icub_vor_update
41e294d
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
238771d
@andrewgait
DataType has moved
56d98f4
@andrewgait
Move icub utilities from examples
75c9e04
@andrewgait
Move icub utilities back to examples
c7a1e60
@andrewgait
Fix imports and add init file
c1e6386
@andrewgait
Do imports more sensibly and update to single copyright year
b42f310
@andrewgait
Apparently pylint was complaining about this
49c7ad8
@andrewgait
Merge remote-tracking branch 'origin/master' into icub_vor_update
071b958
@andrewgait
Missing init py file
f565eb4
@andrewgait
Try this to satisfy pylint instead
a2de770
@andrewgait
Try this setting instead
da95f68
@andrewgait
Try this instead
e671c7b
@andrewgait
This should now work
1fea7a1
@andrewgait
Update script_builder to skip icub_utilities
463af62
@andrewgait
Try a different location for icub_utilities
2a11cac
@andrewgait
More tidying up
08ed4e4
rowleya
rowleya approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - happy if it does what it is meant to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowleya rowleya rowleya approved these changes

@Christian-B Christian-B Awaiting requested review from Christian-B

@pabogdan pabogdan Awaiting requested review from pabogdan

Assignees
No one assigned
Labels
enhancement New feature or request incomplete_left_for_further_release Work to go into a future release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewgait @rowleya @pabogdan @Christian-B