Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing #286

Merged
merged 56 commits into from
Oct 22, 2024
Merged

Typing #286

merged 56 commits into from
Oct 22, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Oct 17, 2024

Builds on #283 which holds any real code changes.

index_is_value.py → mypy.bash is a nuke and a new file. git is confused.

Now checks code but not tests are full typed
mypyd.bash to run this locally

included code changes

  • assert not None
  • make a temporary variable or type or check not None
  • Progress_bar self._chars_per_thing = 1.0
  • Progress_bar unset values changed from int to str values
    • test_log mock subclass changed

Weirdness

  • CamelCaseConfigParser could not get python3.8 format
  • helpful_functions lcm and gcd could not merge the overloads
  • require_subclass mypy does not like the weirdness here

tested by tiny prs (should all be merged)
SpiNNakerManchester/SpiNNMachine#272
SpiNNakerManchester/SpiNNMan#420
SpiNNakerManchester/PACMAN#580
SpiNNakerManchester/SpiNNFrontEndCommon#1221
SpiNNakerManchester/sPyNNaker#1498
SpiNNakerManchester/SpiNNakerGraphFrontEnd#287

Jenkins
SpiNNakerManchester/IntegrationTests#297

@Christian-B Christian-B merged commit e0781d6 into master Oct 22, 2024
10 checks passed
@Christian-B Christian-B deleted the typing branch October 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant