-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing #286
Merged
Merged
Typing #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # spinn_utilities/make_tools/replacer.py # spinn_utilities/progress_bar.py
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #283 which holds any real code changes.
index_is_value.py → mypy.bash is a nuke and a new file. git is confused.
Now checks code but not tests are full typed
mypyd.bash to run this locally
included code changes
Weirdness
tested by tiny prs (should all be merged)
SpiNNakerManchester/SpiNNMachine#272
SpiNNakerManchester/SpiNNMan#420
SpiNNakerManchester/PACMAN#580
SpiNNakerManchester/SpiNNFrontEndCommon#1221
SpiNNakerManchester/sPyNNaker#1498
SpiNNakerManchester/SpiNNakerGraphFrontEnd#287
Jenkins
SpiNNakerManchester/IntegrationTests#297