Allow neo and pyNN versions 0.10 #1165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christian-B
changed the title
This was referenced Apr 13, 2022
Closed
Closed
Christian-B
added
the
incomplete_left_for_further_release
|
Agreed with @rowleya to wait for the fix of NeuralEnsemble/PyNN#708 |
|
master is on neo==0.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #956
We had capped pyNN and Neo due to a bug in the plotting
NeuralEnsemble/PyNN#708 whuich has been fixed
there is another.
NeuralEnsemble/PyNN#750
But there is a temporary work around (revert back) to avoid that one.
This PR allow support for Both version 0.9 and 0.10 and the same time.
I suggest once pynn fixes NeuralEnsemble/PyNN#708 or tells us what we are doing wrong
We support only from that version up.
tested by:
SpiNNakerManchester/IntegrationTests#111
backward compatibility to pyNN/neo 0.9 tested by
#1166
SpiNNakerManchester/IntegrationTests#112
If this is merged address
SpiNNakerManchester/SpiNNakerManchester.github.io#40