Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support vanilla in online mode with new chat signings #3604

Closed
wants to merge 3 commits into from

Conversation

Outfluencer
Copy link
Collaborator

No description provided.

@Outfluencer
Copy link
Collaborator Author

Outfluencer commented Jan 24, 2024

technicly bungeecord uses offline uuids for everything now if ipForward is disabled

@md-5 md-5 mentioned this pull request Jan 28, 2024
4 tasks
@md-5 md-5 self-assigned this Jan 29, 2024
@md-5
Copy link
Member

md-5 commented Jan 29, 2024

Any chance you can see if you can reproduce #3606 and whether this fixes it?

Please and thanks

@md-5
Copy link
Member

md-5 commented Jan 29, 2024

Thanks, looks good subject to question above. Appreciated

@Outfluencer
Copy link
Collaborator Author

Any chance you can see if you can reproduce #3606 and whether this fixes it?

Please and thanks

i'll take a look

@Outfluencer
Copy link
Collaborator Author

Outfluencer commented Jan 29, 2024

Any chance you can see if you can reproduce #3606 and whether this fixes it?

Please and thanks

Can reproduce, by dropping ChatSession packet
This PR fixes the issue

@md-5 md-5 self-requested a review January 29, 2024 19:52
@md-5
Copy link
Member

md-5 commented Jan 29, 2024

Sorry I thought about this more and it is a bit of a change in that now the bungee API methods will also use offline UUIDs despite being only mode.

I need to investigate further whether in fact we can just rewrite the entity / other relevant packets (this is what used to be done)

@Outfluencer
Copy link
Collaborator Author

Outfluencer commented Jan 29, 2024

Sorry I thought about this more and it is a bit of a change in that now the bungee API methods will also use offline UUIDs despite being only mode.

I need to investigate further whether in fact we can just rewrite the entity / other relevant packets (this is what used to be done)

yes a also thought that this would maybe be an issue

@Outfluencer
Copy link
Collaborator Author

Sorry I thought about this more and it is a bit of a change in that now the bungee API methods will also use offline UUIDs despite being only mode.

I need to investigate further whether in fact we can just rewrite the entity / other relevant packets (this is what used to be done)

done
i will make pr

@md-5
Copy link
Member

md-5 commented Apr 13, 2024

Was there ever any progress with this, or still with me?

@Outfluencer
Copy link
Collaborator Author

Was there ever any progress with this, or still with me?

i think i fogot to make the new pr i will look it up now

@Outfluencer
Copy link
Collaborator Author

done in #3650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants