-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support vanilla in online mode with new chat signings #3604
Conversation
the finish method sets the uuid to the offline uuid so the removed code was unnecessary
technicly bungeecord uses offline uuids for everything now if ipForward is disabled |
Any chance you can see if you can reproduce #3606 and whether this fixes it? Please and thanks |
Thanks, looks good subject to question above. Appreciated |
i'll take a look |
Can reproduce, by dropping ChatSession packet |
Sorry I thought about this more and it is a bit of a change in that now the bungee API methods will also use offline UUIDs despite being only mode. I need to investigate further whether in fact we can just rewrite the entity / other relevant packets (this is what used to be done) |
yes a also thought that this would maybe be an issue |
done |
Was there ever any progress with this, or still with me? |
i think i fogot to make the new pr i will look it up now |
done in #3650 |
No description provided.