fix: inverted isEmpty method on ComponentStyle #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code now fits to the method description, however the javadoc fitted to the previous implementation and needs to be updated as well. |
diogotcorreia
force-pushed
the
componentstyle-isempty
branch
from
b0ffee7 to
e00bf45
Compare
|
Thanks, missed that 😅 |
|
Should I add some tests as well? |
|
Yes a test would be great thanks |
diogotcorreia
force-pushed
the
componentstyle-isempty
branch
from
e00bf45 to
1095ff6
Compare
|
I've added two tests, let me know if you want more. |
|
Thank you! I should have made a unit test for this method :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3610
Relates to #3569 and 737d545
cc @2008Choco