send offline uuid to client and server if ip-forward is disabled #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw how do i make my commits signed in intellij? |
Settings -> Version Control -> Git |
|
This looks extremely nice. Tested? |
|
Yes worked fine for me |
md-5
reviewed
Apr 17, 2024
| @@ -62,7 +62,7 @@ public void rewriteServerbound(ByteBuf packet, int oldId, int newId) | |||
| int packetId = DefinedPacket.readVarInt( packet ); | |||
| int packetIdLength = packet.readerIndex() - readerIndex; | |||
|
|
|||
| if ( packetId == spectateId && !BungeeCord.getInstance().getConfig().isIpForward() ) | |||
| if ( packetId == spectateId ) | |||
There was a problem hiding this comment.
Does this change need to be made to all the rewriters?
There was a problem hiding this comment.
yes it does i forgot and did not notice because it makes only a difference if bungeecord is reloaded and ipforward is changed
md-5
pushed a commit
that referenced
this pull request
Apr 17, 2024
|
Thanks! |
thxrben
pushed a commit
to thxrben/BungeeCord
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old pr #3650
i think this pr is a much nicer solution