Close connection if HaProxy Messages is a health check on 2.0 #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there not a response we need to send? |
|
the health checks where passing after this change so i think we dont need to respond. Also bungee only has an HAProxyMessageDecoder and no Encoder, and as i understand we do not respond to this packet |
JonnygamingTv
added a commit
to JonnygamingTv/BungeeCord
that referenced
this pull request
Apr 29, 2024
SpigotMC#3608, SpigotMC#3676: Close connection if HAProxy 2.0 message is a health check
thxrben
pushed a commit
to thxrben/BungeeCord
that referenced
this pull request
Jun 16, 2024
… is a health check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3608