Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bungee command #3763

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Outfluencer
Copy link
Collaborator

retrieve the latest build number async from jenkins rest api
cache the retrived number for 5 minutes
compare with the current build number if possible and show some info how to update

also make the current version that is the output of the command copyable

@Janmm14
Copy link
Contributor

Janmm14 commented Dec 1, 2024

Seems weird to potentially receive 1 answer line after the command instantly and then a second one up to 30 (15+15) seconds later without indication, suggestion: if version needs to be requested, output sth like "Checking latest version...")

  • Change the build version retriever to make public whether it needs to re-check version (for next point)
  • Output sth like "Checking latest version..." if it needs re-checking
  • Why use Instant and not System.currentTimeMillis()? Also I suggest saving the millis of X Minutes into the future?
  • Maybe increase check delay to sth. like 15, 30 or even 60 mins, bungee updates are not as regular.

Additionally I think we should add a new permission (maybe bungeecord.command.bungee.versioncheck) to the version check part - I do not want to allow every player to trigger some http request.

@md-5
Copy link
Member

md-5 commented Dec 1, 2024

Yep, agree on the permission

@Outfluencer Outfluencer requested a review from Janmm14 December 1, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants