Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic curation with metrics #2918

Merged
merged 209 commits into from
Jan 10, 2025

Conversation

anoushkajain
Copy link
Contributor

@anoushkajain anoushkajain commented May 29, 2024

Solves #2479

This PR introduces model-based metric curation in the curation module.

The core functionality is implemented by the auto_label_units, which used scikit-learn pre-trained model in skops format to predict labels based on metrics (could be quality, template, or both).

The PR also adds the possibility to train your own model and to automatically access and apply pre-trained models available on hugging face.

@alejoe91 alejoe91 added the curation Related to curation module label May 30, 2024
@alejoe91 alejoe91 added the hackathon-24 Contributions during the SpikeInterface Hackathon May 24 label Jun 1, 2024
@alejoe91 alejoe91 changed the title automatic curation with metrics Automatic curation with metrics Jun 4, 2024
@alejoe91
Copy link
Member

alejoe91 commented Jan 8, 2025

@chrishalcrow @anoushkajain let's have a final push on this.

Just reviewing the generated docs, there are some failures:

  1. In the Training a model for automated curation
    image

  2. At the end of Model Based Curation

  • si.auto_label_units should be sc.auto_label_units
    image
  • Some rendering/formatting issue at the end:
    image

@alejoe91
Copy link
Member

alejoe91 commented Jan 8, 2025

Question for @anoushkajain and @chrishalcrow

Shouldn't this be "sua"/"mua" and this "noise"/"neuron"?

@alejoe91 alejoe91 marked this pull request as ready for review January 8, 2025 14:21
@alejoe91 alejoe91 dismissed their stale review January 8, 2025 14:21

Everything has been addressed

@alejoe91
Copy link
Member

@chrishalcrow fixed a couple of broken refs in the docs due to the mertics -> metrics correction in the file name.

Merging this! thank you all for working on this!

It's a great contribution for the community :)

@alejoe91 alejoe91 merged commit 9ff3070 into SpikeInterface:main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
curation Related to curation module hackathon-24 Contributions during the SpikeInterface Hackathon May 24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants