Update matroska schema to v4 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix package-lock.json uses private npm registry
StaZhu
approved these changes
Apr 21, 2022
|
Thanks！ |
|
We need to reopen the PR, i did some further testing today and ran into this error oeuillot/node-matroska#10. |
Did you figure out any solution on that? |
|
I tried this suggested solution but it didn't worked.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3 by updating the matroska schema to v4 based on node-matroska.
Additional Changes:
tsconfig.jsonfrom the files list so it does not get published to npm (not required in the published package).package-lock.jsonto v2 and changes the included urls from the current private registry to the official npm registry.