Updates to ci/gha #117
Updates to ci/gha #117
Conversation
…icmonitor-stackstorm-pack'
|
|
||
| - name: Install StackStorm requirements | ||
| # this should run in the st2 checkout | ||
| shell: bash | ||
| working-directory: st2 | ||
| env: | ||
| VIRTUALENV_DIR: "~/virtualenv" |
There was a problem hiding this comment.
OK. Since tilde expansion isn't happening like I thought, so maybe we can do this instead:
| VIRTUALENV_DIR: "~/virtualenv" | |
| VIRTUALENV_DIR: ${{ env.HOME }}/virtualenv |
To do that, we need to add a step at the beginning of the job like this:
- name: add HOME to env context
shell: bash
run: echo ::set-env name=HOME::$HOMEThere was a problem hiding this comment.
I just pushed this into change to the upstream gha branch.
| # TODO: This Makefile has CircleCI assumptions | ||
| run: | | ||
| cp ${ACTION_PATH}/../../.circle/Makefile . | ||
| cp ${{env.ACTION_PATH}}/../../.circle/Makefile . |
There was a problem hiding this comment.
It turns out, github already exposes action_path as an env var, so we can remove ACTION_PATH from the env block and just use $GITHUB_ACTION_PATH
| cp ${{env.ACTION_PATH}}/../../.circle/Makefile . | |
| cp ${GITHUB_ACTION_PATH}/../../.circle/Makefile . |
There was a problem hiding this comment.
I just pushed this to the upstream gha branch
|
@lm-ydubler I just consolidated a bunch of the changes into the gha branch. Could you merge that into your gha branch to reduce the diff? |
|
Thanks, folks for the work you're doing 👍 To connect the dots, just left some notes on the Proposal: Use Github Actions for StackStorm-Exchange CI and Maintenance #63 which is relevant to this PR. |
cognifloyd
force-pushed
the
gha
branch
18 times, most recently
from
c0b8c9c to
27133b6
Compare
|
OK. The build_and_test workflow is good to go on the gha branch. I'm going to close this PR now. We'll open up another PR for any collaboration on the deploy workflow, and then one final PR to merge the gha branch into master. |
This PR includes updates to various files in the gha branch in order to convert the incubator to GHA & get it up and running.