-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Actions workflows and composite actions for packs to use #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
commented
Dec 9, 2021
This was referenced Dec 9, 2021
We did not touch the sections of code that pylint is complaining about, so I'm not fixing the warnings identified by pylint in the CircleCI run. |
mweinberg-cm
approved these changes
Dec 17, 2021
@cognifloyd @lm-ydubler and me just had the call to review the PRs and agreed that the code looks good and is ready to be merged. Great job by both of you guys! |
winem
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of migrating from CircleCI to Github Actions: StackStorm/community#63
I just pushed a commit that switches loading commits from @gha to @master. So, workflows in other repos won't work until this is merged.
.github/actions/py-dependencies/requirements*.txt
are copies of.circle/requirements*.txt
with the expectation that.circle/
will eventually be removed. This keeps the dependencies close to where they are used which simplifies accessing them and maintaining them.