Use Github Actions instead of CirclecI #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
namachieli,
userlocalhost and
a team
as code owners
cognifloyd
requested review from
mickmcgrath13
and removed request for
a team
namachieli
reviewed
Dec 21, 2021
There was a problem hiding this comment.
It all looks good to me. I reviewed and understand what the intent here is, and I don't see anything that stands out to me as problematic. I would prefer if @userlocalhost has a chance to also review.
Withholding approval for now, pending additional reviews.
cognifloyd
commented
Dec 21, 2021
Comment on lines
+21
to
+23
|
|
||
| tag_release: | ||
| needs: build_and_test |
There was a problem hiding this comment.
Maybe add another integration_test workflow that converts the integration_test jobs from CircleCI to GHA.
Make that a reusable workflow (on.workflow_call), and then call it in both build_and_test and release workflows.
Suggested change
| tag_release: | |
| needs: build_and_test | |
| integration_tests: | |
| name: Integration Tests | |
| uses: StackStorm-Exchange/stackstorm-zabbix/.github/workflows/integration_tests.yaml@master | |
| tag_release: | |
| needs: | |
| - build_and_test | |
| - integration_tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of StackStorm/community#63
This PR moves the standard Exchange CI jobs from CircleCI to GHA.
There are some additional integration test jobs that should probably also be converted, so I'm submitting this one as a PR instead of pushing to master like the rest of the packs.
Do you want to convert the other jobs or leave them where they are for now and just merge this?