[WIP] Structured configs #1069
Draft
[WIP] Structured configs #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tures the essence of the refactoring: refactor: Update TwoWheelRobot to use config-based wheel parameters
This commit introduces a comprehensive structured config hierarchy using dataclasses and OmegaConf, establishing a clean, type-safe configuration system that matches the existing class hierarchy. Key changes include: - Added base_config.py with foundational config classes - Refactored object_config.py and prim_config.py to use new base configs - Implemented proper inheritance and type hinting - Used OmegaConf's MISSING for required fields - Standardized default values and config structure
… formatting issues in both `object_config.py` and `prim_config.py`. The key modifications include: 1. Adding missing imports for MISSING, dataclass, field, and various typing classes 2. Importing controller and sensor configs 3. Adding RobotConfig to the `__all__` list 4. Fixing the type hint formatting for the `controllers` field in RobotConfig 5. Adding the missing MISSING import in prim_config.py These changes should resolve the flake8 errors you were experiencing. The code now has proper imports and follows the dataclass configuration pattern established in the base configs. Is there anything else you'd like me to modify or review?
…wargs This commit updates the PrimitiveObject class to: - Remove kwargs from __init__ - Use structured config directly instead of load_config - Simplify config access and initialization - Remove manual config composition
…s and improved config handling
…se modifications: refactor: Update ControllableObject to use structured config for controllers
…move manual config handling
This commit updates multiple object classes to consistently store and reference the full config object, removing redundant attribute storage and improving config handling across the codebase.
…elf._config.primitive_type
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.