-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XIVOmega Plugin #701
Add XIVOmega Plugin #701
Conversation
Hello, is there anything else I need to do to advance this request?? First time submitting a plugin,thanks. @TrainDoctor |
Nothing that's your fault, apologies. Been busy with work and life and didn't get to many PRs, let alone yours 😅. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please remove the backend folder and it's contents as you don't appear to be using that functionality.
- Remove defaults.txt from the defaults folder.
- Remove decky_plugin.pyi as it is out of date and no longer used.
- Please update the license file to include your name or username (whichever is preferred).
- This is my fault, please update your lockfile to the latest (~v 9.0 etc) version. The plugin development side of the wiki was out of date and I only just updated that today.
Once you make these changes the plugin will be good to go to the testing store and once a testing report following the proper format (https://deckbrew.xyz/testing) is completed you'll be good to go to the production store!
Hi @TrainDoctor, changes have been made as requested. Note I also added a small update to main.py to handle an scenario I ran into recently (wlan0 not active at boot time). Please take a look, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ TrainDoctor, changes have been made as requested. Note I also added a small update to main.py to handle an scenario I ran into recently (wlan0 not active at boot time). Please take a look, thanks!
Thanks, and sorry for the delay. Changes look good. Off to testing.
Closing as untested. If you are able to locate a tester in future we will happily accept a re-submission. |
@shingonati0n, if you are able to update this PR with a version of your plugin (please also make sure to bump your version by at least a patch to ensure no conflicts will occur in CI/CD etc) that you have verified with the latest stable versions of Loader then I can re-open this PR. (Please note the below text only applies if you are able to make the requested update, thanks for your understanding). The more plugins that can come back the higher chance you are able to see a tester for your plugin is my hope. I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines. |
XIVOmega
A Steam Deck Plugin (for Decky Loader) to mitigate latency on the Critically Acclaimed MMORPG Final Fantasy XIV. This plugin is the evolution of xivomega which in turn is based on XivMitmLatencyMitigator, XivMitmDocker and XivAlexander. Mitigation is done by using containers via Podman, which comes bundled with SteamOS.
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing
Tested on SteamOS Stable/Beta Update Channel.
Tested on SteamOS Preview Update Channel.