Ackermann odometry library #8

ARK3r · 2023-05-10T15:49:03Z

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
Give your PR a descriptive title. Add a short summary, if required.
Make sure the pipeline is green.
Don’t be afraid to request reviews from maintainers.
New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

Fork the repository.
Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
Commit to your fork using clear commit messages.
Send a pull request, answering any default questions in the pull request interface.
Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

…timeout updated template/ updated .hpp of controller

…ryhere is xyz) inside generated parameters.hpp, removed _ros2 from the namespace name, pkg compiles without any error,

…os2 addition in the namespace naming of the parameters.hpp file

…interface

…troller.hpp

Co-authored-by: Christoph Fröhlich <[email protected]>

Co-authored-by: Márk Szitanics <[email protected]>

Fix compilation

mergify · 2023-05-10T15:49:37Z

⚠️ The sha of the head commit of this PR conflicts with #3. Mergify cannot evaluate rules on this PR. ⚠️

Use time from start passed in from input reference if non-zero in CTG

GiridharBukka and others added 30 commits December 3, 2022 21:27

created pkg and setup controller from templates rtw

2c744de

recreated controller setup outside docker to use rtw branch with ref_…

e3be21f

…timeout updated template/ updated .hpp of controller

modified .yaml and controller methods content

c9b1dad

added odometry.hpp

568f723

modified namespace of odometry.hpp and added odometry.cpp

29ef5f8

spotted issue with namespace naming (has xyz_ros2 when namespace eve…

2671377

…ryhere is xyz) inside generated parameters.hpp, removed _ros2 from the namespace name, pkg compiles without any error,

corrected the copy paste error in the .yaml file which created the _r…

9181e18

…os2 addition in the namespace naming of the parameters.hpp file

added tests yet to debug few tests

ff4c3b9

Corrected formatting.

a1cb0bc

Delete services and comment out to compile.

afe5006

Make compilable on humble.

222a40d

Correct interfaces in ackerman controllers.

72c3ca1

all tests pass

d81513c

added test_time_stamp_zero test

82e7cf2

ackermann odometry

4d7fa99

template state publisher

6e9a519

interfaces check

8544e3c

removed publish_period related code

96a5879

compiles, tests passed, publish_period removed

29df374

state publisher

7f36236

new message published

65c69bc

added feedback_type() method to choose position or velocity hardware …

6e52043

…interface

Code optimization.

c8cbd28

Make controller to compile again.

4d6dced

added unstamped twist topic -clean commit -functional changes

4ab177b

using only one realtime buffer handle

8335f95

Debuging ackermann controller.

dc4a590

updated tests to work with twist and twist_stamped cases

0c54190

modifid config files

20f5319

modified cmakelists

0c84ca6

destogl and others added 27 commits February 8, 2023 16:56

Apply suggestions from code review

7cd6683

Update ackermann_steering_controller/test/test_ackermann_steering_con…

aaf5187

…troller.hpp

Update bicycle_steering_controller/src/bicycle_steering_controller.yaml

2f80658

Last updates of CMake files copyright year and docs.

8f527f1

Update controllers_index.rst

6021447

fix typos

c1d7515

Co-authored-by: Christoph Fröhlich <[email protected]>

Fix typos

563f8a9

Co-authored-by: Christoph Fröhlich <[email protected]>

Merge branch 'master' into ackermann-odometry-library

aa41b9d

Update steering_controllers_library/src/steering_odometry.cpp

9b9cadb

Co-authored-by: Christoph Fröhlich <[email protected]>

Restore control_msgs repo version

c0144cf

Merge branch 'master' into ackermann-odometry-library

bcbc61c

Merge branch 'master' into ackermann-odometry-library

ba54cb2

fix format

2b41621

Fix typo in link

469702c

Braces are good for you

63e4c28

Co-authored-by: Márk Szitanics <[email protected]>

Fix typo

676239e

Add units to parameters

ce4f36a

Fix typo

c609707

Merge branch 'master' into ackermann-odometry-library

cd7622e

fix format again?!

a3083e8

Return update_odometry() instead of return true

c1431af

Update to new signature of update_reference_from_subscribers

d78bb6a

Remove odom member from state publishing (doesn't exist)

092b459

Fix compilation

Fix test compilation

55d158c

fix format

ecdf2a5

Renovate load controller tests

d817144

remove typo

79f5102

ARK3r closed this May 10, 2023

destogl added a commit that referenced this pull request Sep 28, 2023

Merge pull request #8 from SchillingRobotics/ctg-use-time-from-start

dfbd63e

Use time from start passed in from input reference if non-zero in CTG

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ackermann odometry library #8

Ackermann odometry library #8

ARK3r commented May 10, 2023

mergify bot commented May 10, 2023

Ackermann odometry library #8

Ackermann odometry library #8

Conversation

ARK3r commented May 10, 2023

mergify bot commented May 10, 2023