Fix some entities wrongly treated by server #2247
Open
+199
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tornac1234
commented
Jan 7, 2025
tornac1234
commented
- Fix random objects on the map having Constructables not being synced
- Fully treat SpawnRandom monobehaviours on server-side spawning
- Add a cache for prefab placeholder and SpawnRandom parsing, reducing parsing to less than a second (on my machine)
…rly deconstructed (starships and stuff)
…cache for prefab placeholder and SpawnRandom parsing
Measurity
requested changes
Jan 7, 2025
NitroxServer-Subnautica/Resources/Parsers/PrefabPlaceholderGroupsParser.cs
Outdated
Show resolved
Hide resolved
NitroxServer-Subnautica/Resources/Parsers/PrefabPlaceholderGroupsParser.cs
Outdated
Show resolved
Hide resolved
NitroxServer-Subnautica/Resources/Parsers/PrefabPlaceholderGroupsParser.cs
Outdated
Show resolved
Hide resolved
NitroxServer-Subnautica/Resources/Parsers/PrefabPlaceholderGroupsParser.cs
Outdated
Show resolved
Hide resolved
NitroxServer-Subnautica/Resources/Parsers/PrefabPlaceholderGroupsParser.cs
Outdated
Show resolved
Hide resolved
NitroxServer-Subnautica/Resources/Parsers/PrefabPlaceholderGroupsParser.cs
Outdated
Show resolved
Hide resolved
Jannify
requested changes
Jan 8, 2025
Measurity
approved these changes
Jan 8, 2025
Coding-Hen
reviewed
Jan 9, 2025
| } | ||
| else if (typeTreeType.TypeHash.data.SequenceEqual(spawnRandomHash)) | ||
| { | ||
| AssetsFileInstance assetFileInst = am.LoadBundleWithDependencies(assetPaths); |
There was a problem hiding this comment.
Unless I'm really reading this wrong isn't this the same as the AssetsFileInstance before the for loop? Why can't we reuse that rather than reloading the same file?
| @@ -102,10 +102,26 @@ public bool ModifyConstructedAmount(ModifyConstructedAmount modifyConstructedAmo | |||
| Log.Error($"Trying to modify the constructed amount of a non-registered object (GhostId: {modifyConstructedAmount.GhostId})"); | |||
| return false; | |||
| } | |||
|
|
|||
| // Certain entities with a Constructable are just "regular" WorldEntities (e.g. starship boxes) and for simplicity we'll just not persist their progress | |||
| // since their only use is to be deconstructed to give materials to players | |||
There was a problem hiding this comment.
Do we want to raise a ticket for someone to do this one day?
There was a problem hiding this comment.
That's up to you. I could definitely implement it in no time but it'd only be overkill/making the base system persistence a bit more confusing.
dartasen
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.