Simplify use of NonZeroJacobianIndices in Common/itkCompute*.hxx, let SampleFixedImageForJacobianTerms() return std::vector, etc #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed assignment to data members from its default-constructor. Removed duplicated `this->m_FixedImageMask = nullptr` statement. Following C++ Core Guidelines, Oct 3, 2024, "Prefer initialization to assignment in constructors", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-initialize
Removed `this->` when ComputeDisplacementDistribution directly accesses its own data. Also replaced this->m_ScaledCostFunction with Superclass::m_ScaledCostFunction, to make clearer where that data member is from.
`NonZeroJacobianIndicesType` has always been defined as `std::vector` of integers, in itkAdvancedTransform.h, looking at commit 3b50076 (27 Oct 2008), so it's not necessary to manually zero-initialize its elements.
Removed unnecessary `if (region != m_FixedImageRegion)` checks.
Removed unnecessary `nrofsamples` variables.
Removed unnecessary `bandcov.set_size(0, 0)` call. Following C++ Core Guidelines, Oct 3, 2024, Keep scopes small https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-scope
Each of these local typedefs is only used once.
`std::vector<ImageSampleType>` is in general more efficient than `ImageSampleContainerType::Pointer` (which managers an `itk::VectorContainer`, which has an `std::vector<ImageSampleType>` inside).
Using `const auto`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.