STYLE: Use the new ITK 5.2 OptimizerParameters constructors
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified the code by using these two `explicit` constructors, which are added with ITK 5.2:
OptimizerParameters(SizeValueType dimension, const ValueType & value);
OptimizerParameters(const ValueType * inputData, SizeValueType dimension);
Follow-up to pull request #475 commit 6803b26 "COMP: Upgrade ITK from v5.1.1 to v5.2.0"
N-Dekker
commented
Jun 22, 2021
| @@ -56,13 +56,8 @@ StackTransform<TScalarType, NInputDimensions, NOutputDimensions>::SetParameters( | |||
| const NumberOfParametersType numSubTransformParameters = this->m_SubTransformContainer[0]->GetNumberOfParameters(); | |||
| for (unsigned int t = 0; t < this->m_NumberOfSubTransforms; ++t) | |||
| { | |||
| // MS, \todo: the new itk::TransformParameters only have constructors taking 1 argument | |||
There was a problem hiding this comment.
@mstaring This pull request finally fixes the \todo that you wrote many years ago 😃 The new (ITK 5.2) itk::OptmizerParameters does have a few more convenient constructors than before, including one that accepts a data pointer and a size as arguments! No need to use a temporary subarray anymore!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the code by using these two
explicitconstructors, which are added with ITK 5.2:Follow-up to pull request #475 commit 6803b26 "COMP: Upgrade ITK from v5.1.1 to v5.2.0"