Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ImageRandomSamplerSparseMask UseMultiThread support, add GTest unit tests #987

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

N-Dekker
Copy link
Member

@N-Dekker N-Dekker commented Nov 14, 2023

ImageRandomSamplerSparseMask now forwards UseMultiThread to its internal FullSampler, and uses its own ThreaderCallback, instead of the old ThreadedGenerateData mechanism.

Follow-up to:

Also added GoogleTest unit tests.

ImageRandomSamplerSparseMask now forwards `UseMultiThread` to its internal FullSampler, _and_ uses its own ThreaderCallback, instead of the old `ThreadedGenerateData` mechanism.

Follow-up to:

- pull request #973 commit ca9e9ec (ImageRandomSampler)
- pull request #978 commit 1ad43ea (ImageRandomCoordinateSampler)
@N-Dekker N-Dekker merged commit e820cd1 into main Nov 14, 2023
7 checks passed
@N-Dekker N-Dekker deleted the ImageRandomSamplerGTests branch November 14, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant