Add m_RandomCoordinates to ImageRandomCoordinateSampler, and 5 other Sampler code style improvements
#988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a reference to non-const, it would not even be possible to initialize by a pair of empty braces `{}`. And it certainly is not intended.
Improved consistency between the Samplers
The three derived samplers (ImageRandomSampler, ImageRandomCoordinateSampler, ImageRandomSamplerSparseMask) now use a new mechanism to support UseMultiThread.
Reported by Clang: https://releases.llvm.org/15.0.0/tools/clang/docs/DiagnosticsReference.html#wextra-semi Also removed an unnecessary line break.
It appears easier for ImageRandomCoordinateSampler to have its own dedicated `m_RandomCoordinates`, instead of using m_RandomNumberList from its Superclass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.