Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 10 #13

Merged
merged 14 commits into from
Mar 3, 2020
Merged

Issue 10 #13

merged 14 commits into from
Mar 3, 2020

Conversation

lkitching
Copy link
Collaborator

No description provided.

Issue #10 - Allow test suites to be specified within an EDN file and
executed through the CLI. EDN test suites explicitly list the test
files to execute and can also specify the name and test type. Existing
directory and file test suite types are also supported. In all cases,
a data structure is built representing the test suite(s) defined on
the command-line.

Test suites can also include tests from other suites, and exclude
imported tests which are not required.

Add reporting namespace containing TestReporter protocol for reporting
individual test results and the summary for all test executions.

Move repository loading into endpoint namespace.

Remove the two-stage loading and running of test cases and move the
loading into the test execution.
Support defining tests with partial map definitions which are normalised
during the load process.

Add HasPath protocol for retrieving the paths associated with different
sources. Implement for File, URI and URL within a new util namespace.
Implement the existing file extension functions using this protocol and
move them into the util namespace.
Add documentation for defining EDN test suites to README.md.
Rename the key used to include one suite's tests within another from
:extend to :import. Replace all related usages of extend within the
documentation.
Add top-level exception handler to main which displays the contained
exception message and exits.
@lkitching lkitching requested a review from jennet October 11, 2018 15:08
Copy link

@jennet jennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling a specific test suite should be able to be defined before merging this (see #16 )
We should also prob close #15
#14 would be handy but it's definitely not a stopper, low priority

Issue #16 - Allow the test suites to run to be provided as command line
arguments. Any number of suites can be provided, any unknown test
suite names are ignored.
Issue #14 - Allow test suites to reference test directories as well
as individual test files. Directories are loaded in the same way as
directory suites except the containing test suite is defined in the
test file and not inferred from the directory name.
@lkitching
Copy link
Collaborator Author

@jennet - Issues #14 and #16 should now be resolved.

Remove the #resource EDN tag reader used in test suite EDN definitions.
Resolve referenced test cases relative to the test suite source
location - this means tests within suites loaded as resources should
also be resources. This means that test suites can be moved from the
file system to the classpath without needing to update the test
suite definition.

Load test suite files with the name rdf-validator-suite.edn from
the classpath.

Update the README to describe how to define classpath test suites
and how to run rdf-validator through the clojure command-line tool.
@jennet jennet merged commit 1b49319 into master Mar 3, 2020
@jennet jennet deleted the issue_10 branch March 3, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants