34 remove need for direct auth with s3 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
phwissmann
force-pushed
the
34-remove-need-for-direct-auth-with-s3
branch
from
d92db01 to
549f285
Compare
phwissmann
force-pushed
the
34-remove-need-for-direct-auth-with-s3
branch
6 times, most recently
from
ae043ed to
3110222
Compare
phwissmann
force-pushed
the
34-remove-need-for-direct-auth-with-s3
branch
from
3110222 to
cec7c99
Compare
using percentage directly
Add pond as worker pool for multipart uploads
It's composed of the checksums of the parts and not the whole object's digest
phwissmann
force-pushed
the
34-remove-need-for-direct-auth-with-s3
branch
from
8c964a4 to
fc5aa15
Compare
| case task.TransferGlobus: | ||
| err = GlobusTransfer(config.Transfer.Globus, ingestionTask, task_context, ingestionTask.DatasetFolder.Id, datasetFolder, fullFileArray, notifier) | ||
| if err != nil { |
There was a problem hiding this comment.
why add the error handling separately for each transfer case when at line 219 (line 210 before changes), we have a common error handler for both cases? If there's a good reason then the common one should also be removed
| @@ -147,12 +144,15 @@ func (w *TaskQueue) RemoveTask(id uuid.UUID) error { | |||
|
|
|||
| func (w *TaskQueue) ScheduleTask(id uuid.UUID) { | |||
| w.taskListLock.RLock() | |||
| ingestionTask, found := w.datasetUploadTasks.Get(id) | |||
| ingestionTask := w.datasetUploadTasks.GetElement(id) | |||
There was a problem hiding this comment.
is the a specific reason to use GetElement over Get?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how S3 uploads are authenticated: instead of using credentials, it will get presigned urls from a server (using the scicat jwt token to authenticate). This allows to not have to distribute any S3 credentials.
Additionally, there are some tuning parameter for multipart-s3 upload in order to optimally use the available bandwidth