Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'und', 'mul', & 'zxx', too #707

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

sydb
Copy link
Member

@sydb sydb commented Oct 30, 2024

My apologies to potential reviewers. Although this passes Test/ and Test2/, I have not put much work into actually testing that it works. Just too late and I am really tired. Maybe tomorrow afternoon, if someone has not already tested it and merged it.

@sydb sydb added the status: fixUntested Someone has checked in a fix that has been insufficiently tested. label Oct 30, 2024
@sydb sydb added this to the Release 7.58.0 milestone Oct 30, 2024
@sydb sydb requested review from joeytakeda and GusRiva November 25, 2024 03:06
@sydb sydb removed the status: fixUntested Someone has checked in a fix that has been insufficiently tested. label Nov 25, 2024
@sydb
Copy link
Member Author

sydb commented Nov 25, 2024

While I have not tested thoroughly, it passes a few spot-checks.

@HelenaSabel HelenaSabel self-requested a review November 26, 2024 18:34
@trishaoconnor trishaoconnor added the status: pending The original proposer or someone else has been asked to provide an example or further explanation. label Nov 27, 2024
@ebeshero ebeshero self-requested a review December 1, 2024 20:51
Copy link
Member

@ebeshero ebeshero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thoroughly tested this today, and made sure that Guidelines builds and exemplars work. This corrects a bug we recently introduced for processing Schematron constraints in egXML, so I'm approving and merging.

@ebeshero ebeshero removed the status: pending The original proposer or someone else has been asked to provide an example or further explanation. label Dec 2, 2024
@ebeshero ebeshero merged commit e99b32b into dev Dec 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants