-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for classRef/@expand and classSpec/@generate #19
Conversation
@sydb would like to wait to see how the TEI ticket TEIC/TEI#2369 ends up before doing this, so we're holding off for now. |
@@ -392,6 +393,7 @@ | |||
<attDef ident="rend" mode="delete"/> | |||
<attDef ident="style" mode="delete"/> | |||
<attDef ident="rendition" mode="delete"/> | |||
<attDef ident="generate" mode="delete"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEI has committed to ditching this attr. The intent was just to make it a no-op, i.e. to ignore it. But I see no strong reason not to disallow it, as done here.
@@ -375,6 +375,7 @@ | |||
<attDef ident="rend" mode="delete"/> | |||
<attDef ident="style" mode="delete"/> | |||
<attDef ident="rendition" mode="delete"/> | |||
<attDef ident="expand" mode="delete"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEI has not committed to dropping this attr on TEIC/TEI#2369. That said, a) they probably will; and b) until they either drop it or clearly define its semantics, there is no need for us to fret over how to process it. So, at least for now (and probably permanently) it makes sense to me to disallow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HelenaSabel and I merged dev and tested, and all looks good. We'll merge now.
See discussion in TEIC/TEI#2369 -- it makes things easier for us to remove support for classRef/@expand and classSpec/@generate and be upfront about it.