-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase submodule usability #10
Conversation
…when process is called within a submodule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issue
|
||
script: | ||
two_pass_mode_param = params.star_two_pass_mode ? "--twopassMode Basic" : "" | ||
""" | ||
STAR --genomeDir ${params.reference} ${two_pass_mode_param} ${params.additional_args} \ | ||
STAR --genomeDir ${reference} ${two_pass_mode_param} ${params.additional_args} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are missing the definition of input parameter val(reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added missing input parameter in latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Minor changes in reference file calls and automated file name creation to ensure usability of processes in subworkflows.