Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase submodule usability #10

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Conversation

gipohl
Copy link
Contributor

@gipohl gipohl commented Feb 6, 2024

Minor changes in reference file calls and automated file name creation to ensure usability of processes in subworkflows.

@gipohl gipohl requested a review from priesgo February 6, 2024 08:38
Copy link
Collaborator

@priesgo priesgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue


script:
two_pass_mode_param = params.star_two_pass_mode ? "--twopassMode Basic" : ""
"""
STAR --genomeDir ${params.reference} ${two_pass_mode_param} ${params.additional_args} \
STAR --genomeDir ${reference} ${two_pass_mode_param} ${params.additional_args} \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing the definition of input parameter val(reference)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing input parameter in latest commit

@gipohl gipohl requested a review from priesgo February 6, 2024 14:30
Copy link
Collaborator

@priesgo priesgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priesgo priesgo merged commit 3a2fa21 into develop Feb 6, 2024
1 check passed
@priesgo priesgo deleted the increase_submodule_usability branch February 6, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants