fix eslint in multiple packages

Talend · Nov 8, 2023 · abdedd3 · abdedd3
1 parent 30bdeb9
commit abdedd3
Show file tree

Hide file tree

Showing 29 changed files with 272 additions and 47 deletions.
diff --git a/fork/bootstrap-sass/.eslintrc.json b/fork/bootstrap-sass/.eslintrc.json
@@ -1,4 +1,16 @@
 {
   "root": true,
-  "extends": "@talend"
+  "extends": ["eslint:recommended", "plugin:prettier/recommended", "plugin:import/recommended"],
+  "env": {
+    "es6": true,
+    "node": true,
+    "jasmine": true,
+    "jest": true
+  },
+  "parser": "@babel/eslint-parser",
+  "parserOptions": {
+    "ecmaVersion": 6,
+    "sourceType": "module",
+    "requireConfigFile": false
+  }
 }
diff --git a/fork/bootstrap-sass/package.json b/fork/bootstrap-sass/package.json
@@ -38,5 +38,9 @@
   },
   "publishConfig": {
     "access": "public"
+  },
+  "devDependencies": {
+    "@babel/eslint-parser": "^7.22.15",
+    "eslint": "^7.32.0"
   }
 }
diff --git a/fork/dynamic-cdn-webpack-plugin/.eslintrc.json b/fork/dynamic-cdn-webpack-plugin/.eslintrc.json
@@ -1,4 +1,16 @@
 {
   "root": true,
-  "extends": "@talend"
+  "extends": ["eslint:recommended", "plugin:prettier/recommended", "plugin:import/recommended"],
+  "env": {
+    "es6": true,
+    "node": true,
+    "jasmine": true,
+    "jest": true
+  },
+  "parser": "@babel/eslint-parser",
+  "parserOptions": {
+    "ecmaVersion": 6,
+    "sourceType": "module",
+    "requireConfigFile": false
+  }
 }
diff --git a/fork/dynamic-cdn-webpack-plugin/package.json b/fork/dynamic-cdn-webpack-plugin/package.json
@@ -45,8 +45,10 @@
     "webpack": "^5.89.0"
   },
   "devDependencies": {
+    "@babel/eslint-parser": "^7.22.15",
     "all-contributors-cli": "^6.26.1",
     "codecov": "^3.8.3",
+    "eslint": "^7.32.0",
     "html-webpack-plugin": "^5.5.3",
     "jest": "^29.7.0",
     "mz": "^2.7.0",

diff --git a/packages/icons/package.json b/packages/icons/package.json
@@ -44,6 +44,8 @@
     "@babel/preset-env": "^7.23.2",
     "@babel/preset-react": "^7.22.15",
     "@svgr/webpack": "^5.5.0",
+    "@talend/eslint-config": "^12.2.0",
+    "@talend/eslint-plugin": "^1.0.1",
     "@talend/scripts-core": "^16.1.0",
     "@talend/scripts-config-babel": "^13.1.0",
     "@talend/scripts-config-typescript": "^11.1.0",

diff --git a/packages/jsfc/package.json b/packages/jsfc/package.json
@@ -39,6 +39,8 @@
     "json-schema"
   ],
   "devDependencies": {
+    "@talend/eslint-config": "^12.2.0",
+    "@talend/eslint-plugin": "^1.0.1",
     "@talend/scripts-core": "^16.1.0",
     "@talend/scripts-config-react-webpack": "^16.2.0",
     "@talend/scripts-config-typescript": "^11.1.0",

diff --git a/packages/jsfc/src/index.js b/packages/jsfc/src/index.js
@@ -1,7 +1,12 @@
 import tv4index from 'tv4';
+
+// eslint-disable-next-line prettier/prettier
+import canonicalTitleMapImp from './lib/canonical-title-map';
+// eslint-disable-next-line prettier/prettier
 import * as schemaDefaultsImp from './lib/schema-defaults';
+// eslint-disable-next-line prettier/prettier
 import * as sfPathImp from './lib/sf-path';
-import canonicalTitleMapImp from './lib/canonical-title-map';
+
 export { merge } from './lib/merge';
 export { select } from './lib/select';
 export { jsonref } from './lib/resolve';

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tools/babel-plugin-assets-api/.eslintrc.json b/tools/babel-plugin-assets-api/.eslintrc.json
@@ -1,4 +1,16 @@
 {
   "root": true,
-  "extends": "@talend"
+  "extends": ["eslint:recommended", "plugin:prettier/recommended", "plugin:import/recommended"],
+  "env": {
+    "es6": true,
+    "node": true,
+    "jasmine": true,
+    "jest": true
+  },
+  "parser": "@babel/eslint-parser",
+  "parserOptions": {
+    "ecmaVersion": 6,
+    "sourceType": "module",
+    "requireConfigFile": false
+  }
 }
diff --git a/tools/babel-plugin-assets-api/package.json b/tools/babel-plugin-assets-api/package.json
@@ -4,7 +4,7 @@
   "description": "",
   "main": "src/index.js",
   "scripts": {
-    "lint": "echo \"Not possible to use talend-scripts here (risk of circular dependency)\" && exit 0",
+    "lint": "eslint ./src",
     "test": "jest"
   },
   "dependencies": {
@@ -13,9 +13,11 @@
   },
   "devDependencies": {
     "@babel/core": "^7.23.2",
+    "@babel/eslint-parser": "^7.22.15",
     "@babel/preset-env": "^7.23.2",
     "babel-jest": "^29.7.0",
     "babel-plugin-tester": "^10.1.0",
+    "eslint": "^7.32.0",
     "jest": "^29.7.0",
     "react": "^18.2.0"
   },

diff --git a/tools/babel-plugin-assets-api/src/index.test.js b/tools/babel-plugin-assets-api/src/index.test.js
@@ -1,5 +1,6 @@
 import pluginTester, { prettierFormatter } from 'babel-plugin-tester';
 import path from 'path';
+
 import babelPlugin from '.';
 
 pluginTester({

diff --git a/tools/babel-plugin-import-from-index/.eslintrc.json b/tools/babel-plugin-import-from-index/.eslintrc.json
@@ -1,4 +1,16 @@
 {
   "root": true,
-  "extends": "@talend"
+  "extends": ["eslint:recommended", "plugin:prettier/recommended", "plugin:import/recommended"],
+  "env": {
+    "es6": true,
+    "node": true,
+    "jasmine": true,
+    "jest": true
+  },
+  "parser": "@babel/eslint-parser",
+  "parserOptions": {
+    "ecmaVersion": 6,
+    "sourceType": "module",
+    "requireConfigFile": false
+  }
 }
diff --git a/tools/babel-plugin-import-from-index/package.json b/tools/babel-plugin-import-from-index/package.json
@@ -14,17 +14,19 @@
     "url": "https://github.com/Talend/ui.git"
   },
   "scripts": {
-    "lint": "echo \"Not possible to use talend-scripts here (risk of circular dependency)\" && exit 0",
+    "lint": "eslint ./src",
     "test": "jest"
   },
   "dependencies": {
     "semver": "^7.5.4"
   },
   "devDependencies": {
     "@babel/core": "^7.23.2",
+    "@babel/eslint-parser": "^7.22.15",
     "@babel/preset-env": "^7.23.2",
     "babel-jest": "^29.7.0",
     "babel-plugin-tester": "^10.1.0",
+    "eslint": "^7.32.0",
     "jest": "^29.7.0"
   },
   "jest": {