chore: upgrade eslint config deps #4977

jmainguytalend · 2023-11-09T11:01:05Z

What is the problem this PR is trying to solve?
Upgrade deps of scripts-config-eslint to handle.

What is the chosen solution to this problem?
Do upgrade and manage breaking changes if necessary.

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2023-11-09T11:23:52Z

Size Change: +2 B (0%)

Total Size: 13.4 MB

ℹ️ View Unchanged

Filename	Size	Change
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	103 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.3 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js`	636 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	121 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB	0 B
`./packages/components/dist/TalendReactComponents.css`	403 kB	0 B
`./packages/components/dist/TalendReactComponents.js`	2.98 MB	0 B
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB	0 B
`./packages/components/dist/TalendReactComponents.min.css`	210 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js`	661 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB	0 B
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB	0 B
`./packages/containers/dist/TalendReactContainers.js`	539 kB	0 B
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.css`	1.74 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js`	105 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js`	372 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js`	63.6 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.18 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.css`	281 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.js`	1.18 MB	0 B
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.43 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.css`	172 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js`	236 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.48 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.8 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	452 kB	+2 B (0%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.5 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	17.1 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	102 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	51.5 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB	0 B
`./packages/forms/dist/TalendReactForms.css`	39.3 kB	0 B
`./packages/forms/dist/TalendReactForms.js`	778 kB	0 B
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.35 kB	0 B
`./packages/forms/dist/TalendReactForms.min.css`	13.4 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js`	205 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB	0 B
`./packages/http/dist/TalendHttp.js`	24.9 kB	0 B
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B	0 B
`./packages/http/dist/TalendHttp.min.js`	5.33 kB	0 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B	0 B
`./packages/icons/dist/bundle.js`	1.26 kB	0 B
`./packages/icons/dist/info.js`	26.1 kB	0 B
`./packages/icons/dist/react.esm.js`	585 kB	0 B
`./packages/icons/dist/react.js`	623 kB	0 B
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB	0 B
`./packages/icons/dist/talendicons.css`	334 B	0 B
`./packages/icons/dist/TalendIcons.js`	752 kB	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B	0 B
`./packages/icons/dist/TalendIcons.min.js`	606 kB	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B	0 B
`./packages/icons/dist/typeUtils.js`	14.4 kB	0 B
`./packages/jsfc/dist/index.js`	86.8 kB	0 B
`./packages/jsfc/dist/index.js.dependencies.json`	2 B	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B	0 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js`	97.4 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	9.64 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB	0 B
`./packages/storybook-docs/dist/globalStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	398 B	0 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB	0 B
`./packages/theme/dist/bootstrap.css`	172 kB	0 B
`./packages/theme/dist/bootstrap.js`	2.51 kB	0 B
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B	0 B

_{compressed-size-action}

github-actions · 2023-11-09T11:27:43Z

4977

Demo is available here

github-actions · 2023-11-09T11:28:49Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.19% (1271/1425)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.38% (5605/6201)	81.64% (3217/3940)	87.73% (1417/1615)
containers	83.53% (1385/1658)	74.67% (687/920)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
design-system	66.74% (905/1356)	48.59% (433/891)	53.18% (192/361)
faceted-search	85.03% (693/815)	76.63% (269/351)	81.75% (242/296)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.72% (1675/1954)	75.22% (902/1199)	84.43% (472/559)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (62/62)	90.9% (10/11)	100% (16/16)

aamalric-talend

LGTM

aamalric-talend · 2023-11-10T08:56:07Z

tools/scripts-config-eslint/.eslintrc.json

@@ -88,7 +88,9 @@
    "testing-library/custom-renders": "off",
    "testing-library/custom-queries": "off",
    "testing-library/no-node-access": "off",
-    "testing-library/render-result-naming-convention": "off"
+    "testing-library/render-result-naming-convention": "off",
+


why this empty line ?

To be homogeneous with existing format for how to write rules : there is a paragraph for each "rule provider" (see above)

…nt-config-update-deps

jmainguytalend added 3 commits November 8, 2023 17:17

chore: upgrade eslint config deps

c791d0d

Upgrade deps @typescript-eslint

fba714a

Update changeset description

a14edbb

jmainguytalend added the need review label Nov 9, 2023

jmainguytalend self-assigned this Nov 9, 2023

jmainguytalend temporarily deployed to pull_request_unsafe November 9, 2023 11:01 — with GitHub Actions Inactive

jmainguytalend had a problem deploying to pull_request_unsafe November 9, 2023 11:01 — with GitHub Actions Error

Merge branch 'master' into jmainguy/chore/eslint-config-update-deps

cb4d167

jmainguytalend temporarily deployed to pull_request_unsafe November 9, 2023 11:01 — with GitHub Actions Inactive

jmainguytalend had a problem deploying to pull_request_unsafe November 9, 2023 11:01 — with GitHub Actions Error

Update yarn lock

c257bc1

jmainguytalend temporarily deployed to pull_request_unsafe November 9, 2023 11:06 — with GitHub Actions Inactive

Update eslint version used in some packages

21867e1

jmainguytalend temporarily deployed to pull_request_unsafe November 9, 2023 15:19 — with GitHub Actions Inactive

jmainguytalend had a problem deploying to pull_request_unsafe November 9, 2023 15:19 — with GitHub Actions Error

Merge branch 'master' into jmainguy/chore/eslint-config-update-deps

f1bd462

jmainguytalend temporarily deployed to pull_request_unsafe November 9, 2023 15:19 — with GitHub Actions Inactive

jmainguytalend temporarily deployed to pull_request_unsafe November 9, 2023 15:20 — with GitHub Actions Inactive

Fix randomly failing UT

e80bc61

jmainguytalend temporarily deployed to pull_request_unsafe November 9, 2023 16:06 — with GitHub Actions Inactive

mhuchet approved these changes Nov 10, 2023

View reviewed changes

aamalric-talend approved these changes Nov 10, 2023

View reviewed changes

jmainguytalend and others added 2 commits November 10, 2023 11:21

Merge remote-tracking branch 'origin/master' into jmainguy/chore/esli…

f224fd2

…nt-config-update-deps

Merge f224fd2 into 46724c1

a37ef00

jmainguytalend temporarily deployed to pull_request_unsafe November 10, 2023 10:21 — with GitHub Actions Inactive

github-actions bot and others added 2 commits November 10, 2023 10:25

chore: yarn-deduplicate

65f2a5f

Commit to start CI again

39c3fad

jmainguytalend temporarily deployed to pull_request_unsafe November 10, 2023 12:56 — with GitHub Actions Inactive

jmainguytalend merged commit e82cc7f into master Nov 10, 2023
11 checks passed

jmainguytalend deleted the jmainguy/chore/eslint-config-update-deps branch November 10, 2023 14:06

jmainguytalend had a problem deploying to pull_request_unsafe November 10, 2023 14:06 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade eslint config deps #4977

chore: upgrade eslint config deps #4977

jmainguytalend commented Nov 9, 2023

github-actions bot commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023

github-actions bot commented Nov 9, 2023 •

edited

Loading

aamalric-talend left a comment

aamalric-talend Nov 10, 2023

jmainguytalend Nov 10, 2023 •

edited

Loading

chore: upgrade eslint config deps #4977

chore: upgrade eslint config deps #4977

Conversation

jmainguytalend commented Nov 9, 2023

github-actions bot commented Nov 9, 2023 • edited Loading

github-actions bot commented Nov 9, 2023

github-actions bot commented Nov 9, 2023 • edited Loading

aamalric-talend left a comment

Choose a reason for hiding this comment

aamalric-talend Nov 10, 2023

Choose a reason for hiding this comment

jmainguytalend Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Nov 9, 2023 •

edited

Loading

github-actions bot commented Nov 9, 2023 •

edited

Loading

jmainguytalend Nov 10, 2023 •

edited

Loading