Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: message upgrade #5011

Merged
merged 7 commits into from
Nov 28, 2023
Merged

feat: message upgrade #5011

merged 7 commits into from
Nov 28, 2023

Conversation

romainseb
Copy link
Contributor

@romainseb romainseb commented Nov 27, 2023 •
edited
Loading

What is the problem this PR is trying to solve?

  • The size of a message fit the container width while before, it has a max width of 28rem

  • add a new prop titleInfo that allow to display an information message aside the title

  • add new prop additionalIconAction to allow to display an additional button icon instead (there was only the dropdown action available before)

  • rename prop additionalActions to additionalDropdownActions to make the API more explicit

  • remove the shadow on the message to make it more consistent with the rest of the design and integrate better in the page

  • The PR have used yarn changeset to a request a release from the CI if wanted.

  • The PR commit message follows our guidelines

  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review

  • Docs have been added / updated (for bug fixes / features)

  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@romainseb romainseb temporarily deployed to pull_request_unsafe November 27, 2023 14:20 — with GitHub Actions Inactive
@romainseb
t :x
44c3560 
Merge branch 'master' into sromain/feat/messages-upgrade
@romainseb romainseb temporarily deployed to pull_request_unsafe November 27, 2023 15:53 — with GitHub Actions Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe November 27, 2023 16:31 — with GitHub Actions Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe November 27, 2023 16:31 — with GitHub Actions Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe November 27, 2023 16:31 — with GitHub Actions Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe November 27, 2023 16:31 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

5011

:octocat: Demo is available here

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023 •
edited
Loading

Title Lines Statements Branches Functions
assets-api Coverage: 28%
 28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
 89.19% (1271/1425) 80.36% (618/769) 88.91% (361/406)
cmf-cqrs Coverage: 87%
 87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
 69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
 90.39% (5607/6203) 81.62% (3221/3946) 87.63% (1418/1618)
containers Coverage: 84%
 83.53% (1385/1658) 74.67% (687/920) 75.17% (327/435)
dataviz Coverage: 85%
 85.6% (321/375) 66.66% (160/240) 75.64% (118/156)
design-system Coverage: 67%
 66.66% (902/1353) 48.72% (439/901) 53.18% (192/361)
faceted-search Coverage: 85%
 85.03% (693/815) 76.63% (269/351) 81.75% (242/296)
flow-designer Coverage: 70%
 70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 85%
 85.72% (1675/1954) 75.22% (902/1199) 84.43% (472/559)
http Coverage: 100%
 100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
 92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
 81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
 100% (62/62) 90.9% (10/11) 100% (16/16)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023 •
edited
Loading

Size Change: +1.38 kB (0%)

Total Size: 13.4 MB

Filename Size Change
./packages/design-system/dist/TalendDesignSystem.css 282 kB +243 B (0%)
./packages/design-system/dist/TalendDesignSystem.js 1.19 MB +663 B (0%)
./packages/design-system/dist/TalendDesignSystem.min.css 173 kB +223 B (0%)
./packages/design-system/dist/TalendDesignSystem.min.js 237 kB +246 B (0%)
ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.21 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.34 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 103 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 672 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 21.3 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 695 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 164 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.25 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 13 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.29 kB 0 B
./packages/cmf/dist/TalendReactCmf.js 636 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.31 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js 121 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.35 kB 0 B
./packages/components/dist/TalendReactComponents.css 403 kB 0 B
./packages/components/dist/TalendReactComponents.js 2.98 MB 0 B
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.21 kB 0 B
./packages/components/dist/TalendReactComponents.min.css 210 kB 0 B
./packages/components/dist/TalendReactComponents.min.js 662 kB 0 B
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.29 kB 0 B
./packages/containers/dist/TalendReactContainers.css 3.01 kB 0 B
./packages/containers/dist/TalendReactContainers.js 539 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.55 kB 0 B
./packages/containers/dist/TalendReactContainers.min.css 1.74 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js 105 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.6 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 28.9 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js 372 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.15 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.css 12 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js 63.6 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.19 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.43 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.48 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 44.6 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 39.6 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.css 41.5 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 33.3 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 37.8 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js 452 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.5 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.css 17.1 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 102 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.55 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 51.5 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.25 kB 0 B
./packages/forms/dist/TalendReactForms.css 39.4 kB 0 B
./packages/forms/dist/TalendReactForms.js 778 kB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.35 kB 0 B
./packages/forms/dist/TalendReactForms.min.css 13.4 kB 0 B
./packages/forms/dist/TalendReactForms.min.js 205 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.39 kB 0 B
./packages/http/dist/TalendHttp.js 24.9 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 5.33 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 26.1 kB 0 B
./packages/icons/dist/react.esm.js 585 kB 0 B
./packages/icons/dist/react.js 623 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 17.4 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 752 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 606 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 14.4 kB 0 B
./packages/jsfc/dist/index.js 86.8 kB 0 B
./packages/jsfc/dist/index.js.dependencies.json 2 B 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 134 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 21 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.9 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.css 2.4 kB 0 B
./packages/stepper/dist/TalendReactStepper.js 97.4 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 1.27 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.css 1.19 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js 9.64 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 1.31 kB 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 398 B 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.53 kB 0 B
./packages/theme/dist/bootstrap.css 172 kB 0 B
./packages/theme/dist/bootstrap.js 2.51 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

@romainseb romainseb temporarily deployed to pull_request_unsafe November 28, 2023 08:22 — with GitHub Actions Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe November 28, 2023 08:27 — with GitHub Actions Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe November 28, 2023 08:28 — with GitHub Actions Inactive
@romainseb romainseb self-assigned this Nov 28, 2023
@romainseb romainseb temporarily deployed to pull_request_unsafe November 28, 2023 08:28 — with GitHub Actions Inactive
@romainseb romainseb marked this pull request as ready for review November 28, 2023 08:28
@romainseb
Refactor MessagePrimitive component to
e01437a 
conditionally render title and titleInfo
@romainseb romainseb temporarily deployed to pull_request_unsafe November 28, 2023 08:35 — with GitHub Actions Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe November 28, 2023 08:35 — with GitHub Actions Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe November 28, 2023 08:36 — with GitHub Actions Inactive
@romainseb romainseb temporarily deployed to pull_request_unsafe November 28, 2023 08:36 — with GitHub Actions Inactive
Gbacc
Gbacc approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Gbacc Gbacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romainseb romainseb merged commit 0e6c82e into master Nov 28, 2023
12 checks passed
@romainseb romainseb deleted the sromain/feat/messages-upgrade branch November 28, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlcaldeira dlcaldeira dlcaldeira approved these changes

@Gbacc Gbacc Gbacc approved these changes

Assignees

@romainseb romainseb

Labels
need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romainseb @Gbacc @dlcaldeira