Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated structure and added unit/impl tests for pinning #5840

Merged
merged 2 commits into from
Dec 21, 2024
Merged

feat: updated structure and added unit/impl tests for pinning #5840

merged 2 commits into from
Dec 21, 2024

Conversation

will-short
Copy link

  • update test structure to what was discussed in discord
  • added unit testing for row pinning
  • updated implementation testing for row pinning to follow new structure
  • updated helpers/fixtures to follow new structure
  • removed old implementation testing for row pinning

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 20, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ce8fd43.

Command Status Duration Result
nx affected --targets=test:format,test:eslint,t... ❌ Failed 1m 55s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 36s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-20 17:40:03 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 20, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-table

npm i https://pkg.pr.new/@tanstack/angular-table@5840

@tanstack/lit-table

npm i https://pkg.pr.new/@tanstack/lit-table@5840

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/@tanstack/match-sorter-utils@5840

@tanstack/qwik-table

npm i https://pkg.pr.new/@tanstack/qwik-table@5840

@tanstack/react-table

npm i https://pkg.pr.new/@tanstack/react-table@5840

@tanstack/solid-table

npm i https://pkg.pr.new/@tanstack/solid-table@5840

@tanstack/react-table-devtools

npm i https://pkg.pr.new/@tanstack/react-table-devtools@5840

@tanstack/svelte-table

npm i https://pkg.pr.new/@tanstack/svelte-table@5840

@tanstack/table-core

npm i https://pkg.pr.new/@tanstack/table-core@5840

@tanstack/vue-table

npm i https://pkg.pr.new/@tanstack/vue-table@5840

commit: ce8fd43

@KevinVandy KevinVandy merged commit 2860b8b into TanStack:alpha Dec 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinVandy KevinVandy KevinVandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@will-short @KevinVandy