New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor :: sortByGradeNum -> Approval #90 #91

Merged

wjzlskxk merged 2 commits into main from refactor/#90

Nov 21, 2024

Member

wjzlskxk commented Nov 20, 2024 •

edited

Loading

⛳️ 작업 내용

현재 외출, 외박의 기본 정렬 기준이 학반순
위의 방식으로 계속 진행 될 경우 수요일이나 금요일같이 외출, 외박자가 많아지면 신청을 수락하기 어려운 문제 발생
기본 정렬 기준을 학반순 -> 승인 여부 순으로 변경
승인여부에 따른 Select를 이용하면 되지만 사용자들에게 좀 더 빠르게 기능을 이용할 수 있도록 하기 위함

📸 스크린샷

before

외출

외박

after

외출

외박

wjzlskxk added 2 commits

November 21, 2024 08:32


          refactor :: sortByGradeNum -> Approval #90

21a0e53


          refactor :: outsleeping sort #90

2c0231c

wjzlskxk requested review from ftery0 and s1hyun2

November 20, 2024 23:40

ftery0 approved these changes

View reviewed changes

Member

ftery0 left a comment

굳

s1hyun2 approved these changes

View reviewed changes

Collaborator

s1hyun2 left a comment

좋습니다

wjzlskxk merged commit 43a84c9 into main

1 check passed

wjzlskxk deleted the refactor/#90 branch

December 16, 2024 08:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet