-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Void Seed to replace Experience Rod early game #638
Open
ferriarnus
wants to merge
4
commits into
Team-EnderIO:dev/1.21.1
Choose a base branch
from
ferriarnus:exp-changes
base: dev/1.21.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like this idea, nicely thought out :) |
dphaldes
added
Type-Enhancement
New feature or enhancement to existing feature.
MC-1.20.4
labels
Mar 25, 2024
Few gameplay notes:
|
|
Where are we with this PR? |
Besides maybe a proper texture, I think this is done if we agree with the idea |
I'd like to think about this more, happy to help migrate this after the reorganisation |
- added delay when using - make main hand work as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Experience Rod does not fit the idea of a "skulk" theme we want to use for exp. We can however not simply lock the item behind skulk, as it is needed for both the exp vacuum and soul binder, making it essential for progression. To remedie this, I introduce a new item "Void Seeds". This item absorbs exp from exp orbs when in the offhand of a player (similar to mending). This stored exp can then be either drunk by the player to gain levels, or transferred to a tank to use in crafting. However, it is unable to take levels from the player. Once exp has been absorbed by the player, it is stuck on the player.
The Experience Rod and Obelisk will still exist and be able to take exp from the player. We just purely delay it a bit longer, as it is a powerful tool.
TODO
Breaking Changes
List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.
Checklist