New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/#139] : LCK CUP 그룹별 순위 컬러를 변경합니다. (대댓글 링크 첨부를 곁들인) #140

Merged

sohyun127 merged 3 commits into develop from feature/#139-rank-color

Jan 27, 2025

+21 −0

Collaborator

sohyun127 commented Jan 26, 2025

✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁

merge할 브랜치의 위치를 확인해 주세요(main❌/develop⭕)
리뷰가 필요한 경우 리뷰어를 지정해 주세요
P1 단계의 리뷰는 필수로 반영합니다.
Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다.

📌 𝗜𝘀𝘀𝘂𝗲𝘀

closed [UI] : 순위표 팀별 순위 색상 변경 #139

📎𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻

그룹별 순위 컬러 변경
대댓글 링크 첨부
깃헙 secret에 변경된 ip 변경

📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁

순위표	대댓글 링크

💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀

dev, rel 버전 base url 모두 변경되었습니다. 슬랙 또는 노션 확인하셔서 local.properties 파일에 반영해주세요.

sohyun127 added 3 commits

January 26, 2025 20:35


          #139 [ADD] : add lck cup group type

6b7df9a


          #139 [FEAT] : set lck cup rank color

83636a8


          #139 [UI] : set up child comment link

43580e2

sohyun127 added 💟 [UI] 🐱 소현 labels

sohyun127 requested review from a team, Eonji-sw and chanubc and removed request for a team

January 26, 2025 11:44

auto-assign bot assigned sohyun127

Eonji-sw approved these changes

View reviewed changes

Member

Eonji-sw left a comment

LGTM

chanubc approved these changes

View reviewed changes

Member

chanubc left a comment

goooood!

sohyun127 merged commit 88ad3bb into develop

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐱 소현 💟 [UI]