[Autotuner] - Tunable variables check v2 #2640
Draft
+28
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oharboe
suggested changes
Dec 24, 2024
| try: | ||
| result = yaml.safe_load(file) | ||
| except yaml.YAMLError as exc: | ||
| print("[ERROR TUN-0018] Error parsing variables.yaml.") |
There was a problem hiding this comment.
Remove "try/except". This takes actionable information(details of yaml error) and converts it into something that isn't actionable.
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
luarss
force-pushed
the
topic/at-tunable-vars
branch
from
0ff0e0a to
da475f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of old PR due to merge conflicts.