Clang tidy #6497
Clang tidy #6497
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
etc/run-clang-tidy-cached.cc
Outdated
| @@ -125,7 +125,8 @@ static constexpr ConfigValues kConfig = { | |||
| .start_dir = "src/", | |||
| .file_exclude_re | |||
| = "src/sta/" // Don't check 3rd-party submodule | |||
| "|codeGenerator/templates/", | |||
| "|codeGenerator/templates/" | |||
| "|build/", // Don't check generated code | |||
There was a problem hiding this comment.
This should not be necessary, as our .start_dir = "src", meaning we don't follow directories and files outside that to run clang-tidy on.
If there are reports in the clang-tidy output that do point to build/, then it is probably because clang-tidy followed some generated include somewhere and reports things there (do you have an example ?). It won't be fixed by this patch though.
I actually have a fix for that by filtering out messages that don't refer to the file in question, I can probably send a PR later this evening.
There was a problem hiding this comment.
I did see reports in the swig generated code which isn't included anywhere afaik. I suspect it is because the cmake in the src references it.
openroad-ci
force-pushed
the
clang-tidy
branch
from
59dd64b to
3aace7a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Matt Liberty <[email protected]>
Signed-off-by: Matt Liberty <[email protected]>
Signed-off-by: Matt Liberty <[email protected]>
openroad-ci
force-pushed
the
clang-tidy
branch
from
3aace7a to
d34d51c
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
openroad-ci
force-pushed
the
clang-tidy
branch
2 times, most recently
from
f4857e7 to
9636aa4
Compare
Signed-off-by: Matt Liberty <[email protected]>
openroad-ci
force-pushed
the
clang-tidy
branch
from
9636aa4 to
fbc047a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
No description provided.