Tcl versions of Python unit tests #6501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ng <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
Jan 10, 2025
src/odb/test/helper.tcl
Outdated
| # Converted from helper.py | ||
|
|
||
| proc createSimpleDB {} { | ||
| set db [odb::dbDatabase_create] |
There was a problem hiding this comment.
You can use ord::get_db to get the default database with a logger.
There was a problem hiding this comment.
Thanks for the pointer. I've switched to use the default DB for the two cases that need the logger and removed the option to include/exclude the negative tests.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Jeff Ng <[email protected]>
…into tcl-unit-tests
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One note about the test_inst.py and test_iterm.tcl. They both do negative testing, which causes some problems because the DB doesn't have a logger. For the time being, a include_neg_tests parameter is added to the test, which controls whether the expected failure tests should be executed or not. They are disabled by default.