removed dbBlock::duplicate which causes memory corruption issues #6536
Conversation
Signed-off-by: Jeff Ng <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@jeffng-or Could you try merging the latest master branch in this PR? The CI failure seems unrelated to your changes, and a merge should fix it. |
Thanks, I've merged the latest onto my branch. Is that sufficient for Jenkins to pick up the change and re-run it? |
|
clang-tidy review says "All clean, LGTM! 👍" |
Yes, it should be enough. The pipelines restarted now. |
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
merged commit 08da6f1
into
The-OpenROAD-Project:master
Removed the dbBlock::duplicate method, which causes memory corruptions when used in the context of a Python unit test that destroys the DB as part of the tearDown method. The duplicate method doesn't appear to be used in any other OR code after checking .c, .h, *.i, *.tcl, and *.py files.